spotbugs: suppress 4 design-intentional findings#7633
Open
Vest wants to merge 1 commit into
Open
Conversation
- DCN_NULLPOINTER_EXCEPTION @ FormulaFactory.getNEPFormulaFor: NPE is a deliberate signal that the expression is not a simple constant; control falls through to the slower parse path. - DCN_NULLPOINTER_EXCEPTION @ StatValueFacet.getVarID: NPE is caught to translate into an IllegalArgumentException with a clearer error message when a CHANNEL is undefined. - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE @ MovementResultFacet$MoveSorter: Private inner Comparator is never serialized; pcgen does not serialize facet runtime constructs (see spotbugs_ignore.xml SE_BAD_FIELD rule). - REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS @ TransparentFactory.<init>: reflection on refClass is the documented purpose of TransparentFactory; it builds references to CDOM types resolved by name from LST data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@SuppressFBWarningswith one-line rationale to four design-intentional findings:FormulaFactory.getNEPFormulaForNPE is a deliberate signal that the expression is not a simple constant; control falls through to the slower parse path.
StatValueFacet.getVarIDNPE is caught to translate into an
IllegalArgumentExceptionwith a clearer error message when a CHANNEL is undefined.MovementResultFacet$MoveSorterPrivate inner Comparator is never serialized; pcgen does not serialize facet runtime constructs (see
spotbugs_ignore.xmlSE_BAD_FIELD rule).TransparentFactory.<init>Reflection on
refClassis the documented purpose ofTransparentFactory: it builds references to CDOM types resolved by name from LST data.SpotBugs delta verified:
Scoped tests:
./gradlew :test --tests "pcgen.cdom.*"-> 2355 tests, 0 failures.