Skip to content

tablets: Fix some issues where the tablet would not update on a server. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmandaCameron wants to merge 3 commits into
base: main-MC1.21.1
Choose a base branch
from
+12 −4
Open

tablets: Fix some issues where the tablet would not update on a server. #82

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9271009
tablet: Re-initialize the TextBuffer on client initialization.
AmandaCameron Aug 25, 2026
2bb2d59
Merge branch 'main-MC1.21.1' into fix-tablets
AmandaCameron Aug 26, 2026
f1871ff
tablet: Rearrange 594822f987d24572f4795f0e27f9bad975605a90
AmandaCameron Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/main/scala/li/cil/oc/common/item/Tablet.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,13 @@ class TabletWrapper(var stack: ItemStack, var player: Player) extends ComponentI
case Some(buffer: api.internal.TextBuffer) =>
buffer.setMaximumColorDepth(colorDepth)
buffer.setMaximumResolution(80, 25)
buffer match {
case concrete: li.cil.oc.common.component.TextBuffer => {
// For some reason the TextBuffer needs re-initilization here, might be an X/Y Problem though.
concrete.markInitialized()
}
case _ =>
}
}

client.PacketSender.sendMachineItemStateRequest(stack, level.registryAccess())
Expand Down Expand Up @@ -573,16 +580,17 @@ object Tablet {
val tablet = e.getValue
if (tablet.node != null) {
// Server.
if (tablet.autoSave) tablet.writeToNBT(tablet.player.registryAccess())
tablet.machine.stop()
for (node <- tablet.machine.node.network.nodes) {
node.remove()
}

// Cache eviction tears down the live machine. Persist that stopped
// state as well, otherwise a tablet that was just turned off may
// retain its previous running flag while it is in a charger.
tablet.data.isRunning = tablet.machine.isRunning
if (tablet.autoSave) tablet.writeToNBT(tablet.player.registryAccess())

for (node <- tablet.machine.node.network.nodes) {
node.remove()
}
tablet.setChanged()
}
}
Expand Down