Skip to content

Animate robot/drone selection via mcmeta - #81

Open
SquidDev wants to merge 1 commit into
PC-Logix:main-MC1.21.1from
SquidDev:squid/robot-selection
Open

Animate robot/drone selection via mcmeta#81
SquidDev wants to merge 1 commit into
PC-Logix:main-MC1.21.1from
SquidDev:squid/robot-selection

Conversation

@SquidDev

Copy link
Copy Markdown
Collaborator

This moves the robot/drone selection animation to be done via an .mcmeta file, rather than manually. This also adds some missing enableBlend/disableBlend calls1, fixing the translucency of the texture.

Due to limitations in the mcmeta format, the "frame time" is defined in ticks, rather than milliseconds. This means the animation plays out slightly faster, at 20fps rather than 17fps. I don't think this is really noticeable (unless doing a side-by-side comparison), but wanted to check we're happy with the change in behaviour.

Footnotes

  1. Annoyingly blitting with a custom color enables blending, but doing it normally (like here) doesn't, so we have to do it ourselves.

@RobertCochran

Copy link
Copy Markdown
Collaborator

I don't think this is really noticeable (unless doing a side-by-side comparison), but wanted to check we're happy with the change in behaviour.

I suspect no one will seriously care. I doubt the original weird 17fps number was deliberate; it probably just looked good (enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants