Animate robot/drone selection via mcmeta - #81
Open
SquidDev wants to merge 1 commit into
Open
Conversation
Collaborator
I suspect no one will seriously care. I doubt the original weird 17fps number was deliberate; it probably just looked good (enough). |
RobertCochran
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the robot/drone selection animation to be done via an
.mcmetafile, rather than manually. This also adds some missingenableBlend/disableBlendcalls1, fixing the translucency of the texture.Due to limitations in the mcmeta format, the "frame time" is defined in ticks, rather than milliseconds. This means the animation plays out slightly faster, at 20fps rather than 17fps. I don't think this is really noticeable (unless doing a side-by-side comparison), but wanted to check we're happy with the change in behaviour.
Footnotes
Annoyingly
blitting with a custom color enables blending, but doing it normally (like here) doesn't, so we have to do it ourselves. ↩