Conversation
- Introduced feature flags for various eviction policies in `Cargo.toml`, allowing users to enable only the necessary policies for smaller builds. - Updated documentation to reflect the new feature flags and their descriptions, enhancing clarity on usage and configuration. - Modified `bench-support/Cargo.toml` to utilize the `policy-all` feature for comprehensive benchmarking. - Ensured that the new feature flags are integrated into the cache builder and prelude for seamless access to different policies.
- Changed the default feature flags to include specific eviction policies: `policy-s3-fifo`, `policy_lru`, `policy-fast-lru`, `policy_lru_k`, and `policy-clock`. - This update allows for more targeted usage of eviction strategies, enhancing modularity and performance based on expected workload patterns.
- Corrected the naming convention of the `policy_lru` feature flag to `policy-lru` for consistency with other feature flags. - This change enhances clarity and maintains uniformity in the feature flag naming scheme.
- Updated README and various documentation files to clarify that each eviction policy is gated behind a feature flag, improving modularity for builds. - Added feature flag details for each policy in the documentation, ensuring users can easily identify and enable the necessary policies for their use cases. - Included examples for minimal builds and emphasized the benefits of targeted feature usage for performance optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Type of Change
How Has This Been Tested?
Test environment:
Checklist
cargo fmtandcargo clippycargo test)Screenshots (if applicable)
Additional Notes