[REFACTOR](schema) Split system.primitive into numeric and geometric modules#552
Open
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Open
[REFACTOR](schema) Split system.primitive into numeric and geometric modules#552Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Conversation
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
July 10, 2026 23:02 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Seth Fitzsimmons (sethfitz)
force-pushed
the
numeric-types-rename
branch
from
July 20, 2026 17:21
2280da8 to
0df2c59
Compare
Seth Fitzsimmons (sethfitz)
temporarily deployed
to
staging
July 20, 2026 17:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Seth Fitzsimmons (sethfitz)
marked this pull request as ready for review
July 20, 2026 17:24
Seth Fitzsimmons (sethfitz)
requested review from
Roel Bollens (RoelBollens-TomTom) and
Victor Schappert (vcschapp)
July 20, 2026 17:24
…odules overture.schema.system.primitive mixed two unrelated concerns: portable numeric NewTypes (int8, uint32, float64, etc.) and geometric types (BBox, Geometry, GeometryType, GeometryTypeConstraint). The generated reference page this produced was titled "Primitive Types" at system/primitive/primitives even though it only covered numeric types. Numeric types move to a new numeric.py module; BBox and Geometry move to a new geometric package. The primitive package is removed and every import across the workspace (themes, common, codegen, and their tests, including several doctest examples) is updated to the correct module. Remaining "primitive" wording in system-package docstrings, the package READMEs, and the Pydantic guide is retired with it. The aggregate docs pages move with their source: system/numeric.md (title "Numeric Types") and system/geometry.md, both flat under system/ like the existing scalar type pages rather than nested under primitive/. Closes #464. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
Seth Fitzsimmons (sethfitz)
force-pushed
the
numeric-types-rename
branch
from
July 21, 2026 18:05
0df2c59 to
089645f
Compare
Victor Schappert (vcschapp)
left a comment
Victor Schappert (vcschapp)
left a comment
Collaborator
There was a problem hiding this comment.
- Since a couple of MD output filenames changed (
primitive.md- gone;numeric.md- new) are there any external hard-code links to these files we have to keep in sync? - I made one inline comment suggesting maybe
geometry.mdshould becomegeometric.mdfor consistency.
Apart from the above minor questions/comments, fully on board and ready to ship this!
| `system/primitive/geometry.md`. These are hardcoded paths since the types share a single | ||
| Aggregate pages come first. All numeric types point to | ||
| `system/numeric.md`. All geometry types point to | ||
| `system/geometry.md`. These are hardcoded paths since the types share a single |
Collaborator
There was a problem hiding this comment.
Given the model names of geometric/numeric it would make sense to rename the output MD file to geometric.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #464.
Splits
overture.schema.system.primitivealong its two concerns:uint8throughfloat64) move tooverture.schema.system.numericBBoxandGeometrymove tooverture.schema.system.geometricprimitivepackage is removed; imports updated across ~35 filesThe generated reference page for the numeric types moves from
system/primitive/primitives("Primitive Types") tosystem/numeric("Numeric Types"), and the geometry page fromsystem/primitive/geometrytosystem/geometry. Remaining "primitive" wording in system-package docstrings is retired with it.The BBox/Geometry move implements Victor Schappert (@vcschapp)'s suggestion from the issue thread; flagging it here since it wasn't settled there.