Skip to content

[ENHANCEMENT] Added provider, resource, and version parameters to sources #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eric Godwin (ericgodwin) wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ENHANCEMENT] Added provider, resource, and version parameters to sources #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0893ae6
Added provider, resource, and version parameters to the sourcePropert…
ericgodwin May 21, 2026
55a6f6f
Allow null for source provider resource version
Copilot May 21, 2026
2d55be2
Addressed PR comments - added pydantic model, require lowercase, no e…
ericgodwin May 27, 2026
5248fed
Changed wording from produced to contributed
ericgodwin May 27, 2026
2369d81
test: regenerate golden baseline schemas for new source fields
ericgodwin May 28, 2026
0fefe80
style: fix import ordering in test_models.py
ericgodwin May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions counterexamples/buildings/bad-sources-empty-provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
id: overture:buildings:building:1234
type: Feature
geometry:
type: Polygon
coordinates: [[[0, 0], [0, 1], [1, 1], [1, 0], [0, 0]]]
properties:
theme: buildings
type: building
version: 1
sources:
- dataset: MyGreatDataset
property: "/geometry"
provider: ""
resource: ""
version: ""
26 changes: 26 additions & 0 deletions examples/buildings/sources-with-version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
id: overture:buildings:building:1234
type: Feature
geometry:
type: Polygon
coordinates: [[[0, 0], [0, 1], [1, 1], [1, 0], [0, 0]]]
properties:
theme: buildings
type: building
version: 1
sources:
- property: "/geometry"
dataset: osm-planet
provider: osm
resource: planet
version: '2078-08-28T14:44:41Z'
- property: "/properties/name"
dataset: metaML-buildings
provider: meta
resource: ml-buildings
version: 'abcdef'
- property: "/properties/height"
dataset: microsoft-buildings
provider: microsoft
resource: buildings
version: '352'
21 changes: 21 additions & 0 deletions packages/overture-schema-addresses-theme/tests/address_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/bathymetry_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/infrastructure_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,16 +384,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/land_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,16 +257,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/land_cover_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/land_use_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,16 +335,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-base-theme/tests/water_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-buildings-theme/tests/building_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,16 +371,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
21 changes: 21 additions & 0 deletions packages/overture-schema-buildings-theme/tests/building_part_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,16 +257,37 @@
"title": "Property",
"type": "string"
},
"provider": {
"description": "The provider label (lowercase with no white space) for the entity that contributed this data\n(e.g., osm, meta, esri).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Provider",
"type": "string"
},
"record_id": {
"description": "Identifies the specific record within the source dataset where the source data can\nbe found.\n\nThe format of record identifiers is dataset-specific.",
"title": "Record Id",
"type": "string"
},
"resource": {
"description": "The subject or type of data contributed by the provider (lowercase with no white space)\n(e.g., planet, buildings, division-names).",
"minLength": 1,
"pattern": "^[a-z0-9][a-z0-9._-]*$",
"title": "Resource",
"type": "string"
},
"update_time": {
"description": "Last update time of the source data record.",
"format": "date-time",
"title": "Update Time",
"type": "string"
},
"version": {
"description": "A sortable identifier for the specific snapshot of the resource\n(e.g., 2026-02-13, 5.3, A5692).",
"minLength": 1,
"pattern": "^\\S+$",
"title": "Version",
"type": "string"
}
},
"required": [
Expand Down
Loading
Loading