Skip to content

Remove OAuth1.0 and basic authentication #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarelM merged 8 commits into from
May 28, 2025
Merged

Remove OAuth1.0 and basic authentication #12

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f85811
Remove OAuth1.0
HarelM Jan 12, 2025
325a9e6
Update tests to use .net 8
HarelM Jan 12, 2025
4ca432a
Removing basic Auth. Updating Auth tests to use oauth2.
blackboxlogic May 28, 2025
6374350
Remove abstract auth client class and simplify hierarchy
HarelM May 28, 2025
811b226
Remove inheritance and use only interfaces. Add doc comments to inter…
HarelM May 28, 2025
7dd1ce7
Bump version number
blackboxlogic May 28, 2025
eb7dd09
Allow easier testing
HarelM May 28, 2025
14afe0c
Merge remote-tracking branch 'origin/remove-auth1' into remove-auth1
HarelM May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OsmSharp.IO.API.Tests/OsmSharp.IO.API.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
6 changes: 0 additions & 6 deletions OsmSharp.IO.API/ClientsFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ public IAuthClient CreateBasicAuthClient(string username, string password)
return new BasicAuthClient(_httpClient, _logger, _baseAddress, username, password);
}

/// <inheritdoc/>
public IAuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret)
{
return new OAuthClient(_httpClient, _logger, _baseAddress, consumerKey, consumerSecret, token, tokenSecret);
}

/// <inheritdoc/>
public IAuthClient CreateOAuth2Client(string token)
{
Expand Down
9 changes: 0 additions & 9 deletions OsmSharp.IO.API/IClientsFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@ public interface IClientsFactory
/// <param name="password"></param>
/// <returns></returns>
IAuthClient CreateBasicAuthClient(string username, string password);
Comment thread
HarelM marked this conversation as resolved.
Outdated
/// <summary>
/// Creates a client that will use OAuth 1.0 credentials provided from the OAuth OSM page
/// </summary>
/// <param name="consumerKey"></param>
/// <param name="consumerSecret"></param>
/// <param name="token"></param>
/// <param name="tokenSecret"></param>
/// <returns></returns>
IAuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret);

/// <summary>
/// Creates a client that will use OAuth 2.0 credentials provided from the OAuth OSM page
Expand Down
53 changes: 0 additions & 53 deletions OsmSharp.IO.API/OAuthClient.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions OsmSharp.IO.API/OsmSharp.IO.API.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,13 @@
</PropertyGroup>

<ItemGroup>
<None Include="..\README.md" Pack="true" PackagePath=""/>
<None Include="..\README.md" Pack="true" PackagePath="" />

</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.0.2" />
<PackageReference Include="OAuth.DotNetCore" Version="3.0.1" />
<PackageReference Include="OsmSharp" Version="7.0.0-pre022" />
</ItemGroup>

Expand Down