Ptero support#289
Conversation
Was requested in the pull request, so you can skip the special handling.
| "AutoPlug is able to update itself automatically.", | ||
| "Its strongly recommended to have this feature enabled,", | ||
| "to benefit from new features, bug fixes and security enhancements.", | ||
| "Pterodactyl-managed servers disable this at runtime to avoid restart loops.", |
There was a problem hiding this comment.
No need for this comment since the self-updater gets disabled automatically for ptero users.
| self_updater_safe_mode = put(name, "self-updater", "safe-mode").setDefValues("true").setComments( | ||
| "If AutoPlug is disabled, it will update itself without advanced compatibility. Self-updating on Ptero will work in the same way as it does when not on Ptero.", | ||
| "Its strongly recommended to have this feature enabled on non AutoPlug specific eggs," |
There was a problem hiding this comment.
What about something easier to read and understand: "If you are running AutoPlug via Pterodactyl Panel, the self-updater is disabled to avoid crashes. Set to false to force the self-updater to run anyways."
There was a problem hiding this comment.
This is extremly misleading. My Code have a specific path for Ptero which does update itself.
There was a problem hiding this comment.
@Zoriot my bad I thought you disabled the self-updater with that change, not the java updater.
Thus please add the safe-mode to the java-updater not the self-updater.
Cool that the self-updater now works on petero by simply replacing the running jar haha. Where you able to test that this works?
self-updater.safe-modeconfig option, if disabled it skips the special handling.Closes #287.
Ptero detection could be improved. Was just generated by GitHub Copilot and worked fine.