fix: Replace Lato with Sailic and Inter fonts (#660)#672
Open
jose-blockchain wants to merge 2 commits intoOriginProtocol:masterfrom
Open
fix: Replace Lato with Sailic and Inter fonts (#660)#672jose-blockchain wants to merge 2 commits intoOriginProtocol:masterfrom
jose-blockchain wants to merge 2 commits intoOriginProtocol:masterfrom
Conversation
- Replace Lato with Inter for body text and smaller elements - Replace Lato with Sailic for larger text and headings - Update Google Fonts import in base.html - Update all CSS files, HTML templates, email templates, and SVG files - Fixes issue OriginProtocol#660
- Add sans-serif fallback to all Inter and Sailic font-family declarations - Ensures proper fallback if fonts fail to load - Prevents UI breaking when fonts are unavailable
Author
|
please review @DanielVF @nick @ryana @andrewhyde @matt-bullock if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Problem:
The website was using the Lato font throughout, but the brand guidelines specify that Sailic should be used for larger text/headings and Inter should be used for body text. This inconsistency with the brand identity needed to be corrected (issue #660).
Solution:
base.htmlto load Sailic and Intersans-seriffallbacks to all font declarations to ensure graceful degradation if fonts fail to loadWhy this solution is better:
Checklist:
sans-seriffallbacksRelated Issue
Closes #660