Skip to content

[ARM] Ether ARM#281

Draft
clement-ux wants to merge 1 commit into
mainfrom
clement/ether-arm-fresh-deploy
Draft

[ARM] Ether ARM#281
clement-ux wants to merge 1 commit into
mainfrom
clement/ether-arm-fresh-deploy

Conversation

@clement-ux

@clement-ux clement-ux commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:

  • Add fresh-deploy EtherARM.
  • Remove legacy upgrade storage from AbstractARM and pack withdrawal requests by deriving shares from cumulative queued shares.
  • Expose withdrawalRequestShares() and update tests/helpers for the new withdrawalRequests() shape.

Reason:

  • The ETH ARM will be deployed from scratch, so legacy upgrade storage is no longer needed.
  • Deriving request shares saves one storage slot per withdrawal request while keeping loss socialization through escrowed shares.

@clement-ux clement-ux changed the title Add fresh deploy Ether ARM [ARM] Ether ARM Jun 25, 2026
naddison36
naddison36 reviewed Jun 26, 2026
View reviewed changes

@naddison36 naddison36 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the deprecated storage slots for now just in case we change our minds and want to upgrade the existing EtherFi and Lido ARMs

Comment thread src/contracts/AbstractARM.sol
/// @dev Legacy single-base storage. Keep this prefix unchanged for existing proxy upgrades.
/// These fields are retained for storage/ABI compatibility and are not the source of truth for
/// multi-base swap pricing.
uint256 internal _deprecatedTraderate0;

@naddison36 naddison36 Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep these for now as it gives us the option to upgrade the Lido and EtherFi ARMs if we change our minds

@clement-ux clement-ux marked this pull request as draft June 26, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naddison36 naddison36 naddison36 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clement-ux @naddison36