Add persistent CDCL-assisted cube generation#58
Merged
Conversation
isPANN
marked this pull request as ready for review
July 23, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Region branching evaluates many propagation candidates, while the emitted cubes are ultimately solved by CDCL. Previous integration attempts either performed redundant propagation, treated native implications as artificial assumptions, or allowed solver search to blur the CnC boundary. This change keeps the architecture explicit: native structure chooses branches, the cuber-side CDCL solver performs one learned propagation per committed branch, and unrestricted solving remains in conquer workers.
The CaDiCaL assumption-propagation path performs conflict analysis outside its normal search loop, so its learned database would otherwise never run the usual reduction schedule. RustSAT and
rustsat-cadicalare pinned toisPANN/rustsat@24c202c, a five-file wrapper patch that removes an upstream debug print and exposes a narrow maintenance hook calling CaDiCaL's own reduction policy. No upstream solver sources are vendored in this repository.Impact
Validation
cargo test --all-targetsPYTHONPATH=. uv run pytest -q— 42 passedcargo clippy --all-targets -- -A clippy::int-plus-one -A clippy::needless-range-loop -A clippy::manual-div-ceil -A clippy::manual-contains -A clippy::manual-is-multiple-of -D warningscargo fmt --all -- --checkcargo test --test cnc_cuber_trace— 12 passed after the final trace-format cleanupPYTHONPATH=. uv run pytest -q tests/test_cnc_trace_mechanism.py— 11 passed after the final trace-format cleanup