V24.1#546
Merged
Merged
Conversation
…tale cached services
avermeil
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the library to Google Ads API v24.1, depending on
google-ads-node@24.1.0-beta.0andgoogle-gax@^5.0.7. Published to npm under thebetadist-tag as24.1.0-beta.0for testing ahead of the stable release.Alongside the version upgrade, this branch fixes several bugs surfaced during a review of the parsing, streaming, and service-caching code paths.
Version upgrade
@isaacs/ttlcachefloor raised to^1.4.0(required forcheckAgeOnGet)ReservationService,YouTubeVideoUploadServiceReservationRequestType,PreviewType, newExperimentTypevalues), and fields (segments.mobile_device_platform,customer_user_access.passkey_enabled)Breaking changes
parse()message-typed leaves now return plain objects instead of protobuf message instances, with all nested int64 values converted fromLongto JavaScript numbers (e.g.change_event.old_resource). Code reading.low/.highfrom nested values must use the plain numbers. Values aboveNumber.MAX_SAFE_INTEGERlose precision, consistent with existing behaviour for directly-selected fields.Fixes
resource_namefor ten view resources (incl.keyword_view,paid_organic_search_term_view) were dropped from parsed results by a code-generation bug; they are now included.getFieldMask()now throws a descriptiveErroron circular references (was aRangeErrorstack overflow) and treats typed arrays andLongvalues as leaves instead of recursing into them. Update masks built from payloads containingLongvalues previously included invalid.low/.high/.unsignedpaths that the API rejected.close()calls during gRPC service cache eviction are now caught instead of surfacing as unhandled promise rejections (the dispose callback was previouslyasyncand fire-and-forget)undefinedfromloadService; stale clients past TTL are not returnedlistAccessibleCustomers()closes its one-shotCustomerServiceClientinstead of caching itFAILURE_KEYdrifts from the installed package's API versionCode-generation fix
resource_namedetection regex used the/gflag with.test(), carryinglastIndexbetween calls and skipping resource names tested consecutively — the cause of the ten missing entries above.Test plan
yarn testgreenlatest