Skip to content

Add new compiler flag to skip directories#367

Draft
emnul wants to merge 1 commit intoupgrade-contracts-versions-0.28.0from
add-filter-dir-option
Draft

Add new compiler flag to skip directories#367
emnul wants to merge 1 commit intoupgrade-contracts-versions-0.28.0from
add-filter-dir-option

Conversation

@emnul
Copy link
Contributor

@emnul emnul commented Feb 4, 2026

This PR is part of #366

We're not actively maintaining contracts archive folder, so there's no need to compile files in that folder during the build process. However, at this time we compile all files in the src directory by default. We could enumerate all directories except the archive directory in our package.json scripts, but it's error prone and does not scale.

This PR adds a new compiler flag to the compact compiler tool that would allow us to specify directories to skip over during the compilation process solving the pain point described above

TODO:
[ ] - Add tests

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-filter-dir-option

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xisk
Copy link
Member

0xisk commented Feb 25, 2026

@emnul I think this PR solves it: OpenZeppelin/compact-tools#68 could you confirm?

@0xisk 0xisk added the enhancement New feature or request label Feb 25, 2026
@0xisk 0xisk moved this from Backlog to In progress in OZ Development for Midnight Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants