Skip to content

Support spine skins#578

Merged
MakinoharaShoko merged 1 commit intodevfrom
support-spine-skins
Apr 1, 2026
Merged

Support spine skins#578
MakinoharaShoko merged 1 commit intodevfrom
support-spine-skins

Conversation

@MakinoharaShoko
Copy link
Copy Markdown
Member

@MakinoharaShoko MakinoharaShoko changed the base branch from main to dev March 25, 2026 12:25
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the animation capabilities of the editor by introducing support for Spine animation skins and a powerful new multi-segment animation command. It also improves user experience by implementing robust client-side file path validation with clear visual warnings, ensuring more reliable asset management.

Highlights

  • Spine Skin Support: Implemented support for Spine animation skins, allowing users to select different skins for Spine models within the editor. This includes parsing skin data from Spine JSON files and providing a UI control for selection.
  • Multi-Segment Animation Command: Introduced a new setTempAnimation command and a dedicated editor component to define complex, multi-segment animations. Users can now create sequences of animation frames, each with its own transform, duration, and easing function.
  • Enhanced File Path Validation: Improved client-side validation for file paths, adding a broader range of illegal characters (including #, %, &, ?, @) and providing visual feedback to the user when an invalid path is detected. Semicolons in file names are now escaped.
  • Localization Updates: Added and updated numerous localization strings across English, Japanese, and Simplified Chinese to support the new Spine skin features, multi-segment animation controls, and file path validation messages.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality to select and apply Spine skins within the ChangeFigure component, enhancing the graphical editor's capabilities for Spine animations. This includes adding state management for skins, parsing skin data from Spine JSON, and integrating a UI for skin selection. Additionally, the PR refactors locale files, notably by replacing a specific error message detailing forbidden characters in filenames with a more general one. Review feedback suggests that restoring the more detailed error message or providing documentation for forbidden characters would improve user experience.

Comment on lines 880 to -881
msgid "文件名"
msgstr "File name"

msgid "文件名不可包含特殊符号: '/\\\\:*?\"<>|'"
msgstr "File name cannot contain special characters: '/\\\\:*?\"<>|'"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

移除了包含具体特殊字符列表的错误消息。虽然保留了更通用的错误消息,但提供具体字符列表可能对用户更友好,有助于他们理解哪些字符是禁止的。建议考虑恢复更详细的错误提示,或者在文档中明确说明。

Comment on lines 880 to -881
msgid "文件名"
msgstr "ファイル名"

msgid "文件名不可包含特殊符号: '/\\\\:*?\"<>|'"
msgstr "ファイル名に特殊記号は使用できません: '/\\\\:*?\"<>|'"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

移除了包含具体特殊字符列表的错误消息。虽然保留了更通用的错误消息,但提供具体字符列表可能对用户更友好,有助于他们理解哪些字符是禁止的。建议考虑恢复更详细的错误提示,或者在文档中明确说明。

Comment on lines 880 to -881
msgid "文件名"
msgstr "文件名"

msgid "文件名不可包含特殊符号: '/\\\\:*?\"<>|'"
msgstr "文件名不可包含特殊符号: '/\\\\:*?\"<>|'"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

移除了包含具体特殊字符列表的错误消息。虽然保留了更通用的错误消息,但提供具体字符列表可能对用户更友好,有助于他们理解哪些字符是禁止的。建议考虑恢复更详细的错误提示,或者在文档中明确说明。

@MakinoharaShoko MakinoharaShoko merged commit c73de4d into dev Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

为 Spine 加入 skin 参数的写入支持

2 participants