Skip to content

fix: remove animation before set effect #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakinoharaShoko merged 3 commits into from
Mar 21, 2026
Merged

fix: remove animation before set effect #899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dabcc94
fix: remove animation before set effect
HardyNLee Mar 14, 2026
687eb9e
Merge branch 'dev' into pr/899
MakinoharaShoko Mar 21, 2026
f47ed34
fix: update removeAnimationByTargetKey to handle multiple animations
MakinoharaShoko Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/webgal/src/Core/controller/stage/pixi/PixiController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,11 @@ export default class PixiStage {
this.removeAnimationByIndex(index);
}

public removeAnimationByTargetKey(targetKey: string) {
const index = this.stageAnimations.findIndex((e) => e.targetKey === targetKey);
this.removeAnimationByIndex(index);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

目前的实现使用了 findIndex，它只会找到并移除第一个匹配 targetKey 的动画。如果一个目标上可能存在多个动画，这可能会导致其他动画仍在运行。

为了确保移除目标上的所有动画，建议使用循环来查找并移除所有匹配的动画。这样可以使该功能在处理边缘情况时更加健壮。

    let index;
    while ((index = this.stageAnimations.findIndex((e) => e.targetKey === targetKey)) !== -1) {
      this.removeAnimationByIndex(index);
    }

}

public removeAnimationWithSetEffects(key: string) {
const index = this.stageAnimations.findIndex((e) => e.key === key);
if (index >= 0) {
Expand Down
1 change: 1 addition & 0 deletions packages/webgal/src/Core/util/syncWithEditor/webSocketFunc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export const webSocketFunc = () => {
...(effect.transform?.scale ?? {}),
},
};
WebGAL.gameplay.pixiStage?.removeAnimationByTargetKey(effect.target);
webgalStore.dispatch(stageActions.updateEffect({ target: effect.target, transform: newTransform }));
} catch (e) {
logger.error(`无法设置效果 ${message.message}, ${e}`);
Expand Down
Loading