Update ca_last_update/crl_last_update on HTTP 304#524
Merged
Conversation
A 304 Not Modified response confirms the local CA certificate or CRL is current, so the refresh-interval TTL should be reset. Previously ca_last_update (backed by ca.pem's mtime) never advanced past the initial download in steady state, so every agent run saw a stale mtime and re-issued the conditional GET regardless of ca_refresh_interval. The CRL path had the same structural issue but was latent because CRL endpoints typically respond 200 often enough that save_crls bumps the mtime naturally. Fix it for symmetry. Fixes #435 Signed-off-by: SAY-5 <say.apm35@gmail.com>
Contributor
Author
|
rebase of #440 |
Sharpie
approved these changes
Jul 6, 2026
corporate-gadfly
approved these changes
Jul 6, 2026
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 304 Not Modified response confirms the local CA certificate or CRL is current, so the refresh-interval TTL should be reset. Previously ca_last_update (backed by ca.pem's mtime) never advanced past the initial download in steady state, so every agent run saw a stale mtime and re-issued the conditional GET regardless of ca_refresh_interval.
The CRL path had the same structural issue but was latent because CRL endpoints typically respond 200 often enough that save_crls bumps the mtime naturally. Fix it for symmetry.
Fixes #435
Short description
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent