Remove filetimeout deprecation warning#419
Open
silug wants to merge 1 commit into
Open
Conversation
silug
force-pushed
the
undeprecate-filetimeout
branch
from
783a189 to
f8b1259
Compare
The filetimeout setting was deprecated in favor of JRuby timers, but since we're moving away from the JVM the fine-grained control is useful again. Remove the deprecation warning and restore full setting semantics. Fixes OpenVoxProject#345. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
silug
force-pushed
the
undeprecate-filetimeout
branch
from
81209de to
161eb52
Compare
Contributor
|
I am not quite sure how this option differs from the environment timeout setting. Do we need both options? |
Contributor
Author
@bastelfreak My understanding is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The filetimeout setting was deprecated in favor of JRuby timers, but since we're moving away from the JVM the fine-grained control is useful again. Remove the deprecation warning and restore full setting semantics.
Fixes #345.
Checklist
I have:
Signed-off-byannotation to each of my commits