Fix bolt guide crash when using rainbow formatter#230
Fix bolt guide crash when using rainbow formatter#230op-ct wants to merge 2 commits intoOpenVoxProject:mainfrom
bolt guide crash when using rainbow formatter#230Conversation
|
I'm not quite sure I understand how this was failing before... |
I'm not sure I understand why the variety of method signatures in https://github.com/search?q=repo%3AOpenVoxProject%2Fopenbolt%20print_topics&type=code |
In 759f54c, the argument passed into the outputters' |
@binford2k I'm not certain of the original reasoning behind the additional FWIW, the same commit (759f54c) updated the {"topics":["debugging","inventory","links","logging","module","modulepath","project","targets","transports"]}The |
|
@op-ct that makes this method explanation quite incorrect then! This mismatch is what threw me off. Think you could fix that comment and add a bit like "we don't need the keyword argument; it's interpreted a hash and thus this outputs semantically correct json." |
a8af31e to
45d66c4
Compare
Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
2361093 to
5cc829c
Compare
Ever since commit 759f54c, the method signatures for the various format outputters (`json`, `human`, `rainbow`) have been inconsistent. This patch removes unused/unneccessary `**kwargs`, standardizes arguments as `(topics: [<Array of guide names>]`), and updates method documentation to reflect their actual behavior. Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
5cc829c to
11ea72b
Compare
Short description
Fixes #229
Follows the example of the
humanoutputter.Checklist
I have:
Signed-off-byannotation to each of my commits