Skip to content

SESSION-2: handler mutation-propagation discipline#65

Draft
JarbasAl wants to merge 1 commit into
devfrom
spec/session2-mutation-discipline
Draft

SESSION-2: handler mutation-propagation discipline#65
JarbasAl wants to merge 1 commit into
devfrom
spec/session2-mutation-discipline

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Extracted from the CONVERSE-1 feature PR (#25) per the 1 file, 1 PR rule — this is the only edit to ovos-session-2.md.

Change (ovos-session-2.md §2.4)

A handler that mutates session in-place but emits no Message has no bus-visible way to propagate those mutations. The handler-lifecycle trio .complete (PIPELINE-1 §8) is orchestrator-emitted from the dispatch context and does not reflect handler-side in-place changes (especially out-of-process). Such a handler MUST emit at least one Message (ovos.utterance.speak or ovos.session.sync per §2.7) for the state to appear in terminal events.

Clarification of existing behaviour — backwards-compatible (V1), Version unchanged. Adds the missing SESSION-2 CHANGELOG section.

CONVERSE-1 (#25) drops this companion edit and forward-references this PR.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f513d304-49b9-4df9-b4c8-e7ecc644753e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/session2-mutation-discipline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl force-pushed the spec/session2-mutation-discipline branch from bba3e4a to 5f3aaee Compare June 22, 2026 17:28
@JarbasAl JarbasAl force-pushed the spec/session2-mutation-discipline branch from 5f3aaee to c9b2726 Compare June 23, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant