Cmake: build .app bundle on macOS, added OTIO icon#18
Draft
timlehr wants to merge 1 commit intoOpenTimelineIO:mainfrom
Draft
Cmake: build .app bundle on macOS, added OTIO icon#18timlehr wants to merge 1 commit intoOpenTimelineIO:mainfrom
timlehr wants to merge 1 commit intoOpenTimelineIO:mainfrom
Conversation
Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
jminor
requested changes
May 22, 2024
Member
jminor
left a comment
jminor
left a comment
There was a problem hiding this comment.
Tim, this looks okay to me. What is left to make this non-draft?
|
|
||
| add_executable(raven) | ||
| if(APPLE) | ||
| set(APP_BUNDLE_IDENTIFIER "com.opentimelineio.raven") |
Member
There was a problem hiding this comment.
We have opentimeline.io but not opentimelineio.com domain. So this could be io.opentimeline.raven
Collaborator
Author
|
@jminor We are using it on our end, but I didn't think about stuff like the domain, bundle name, proper icon ... Did you build it and have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily for reference: This change configures cmake to build an .app bundle for Raven and adds the OTIO icon as a temporary icon for the bundle.