Makefile: update to GIMP3-compatible command-line#95
Merged
frosch123 merged 1 commit intoOpenTTD:masterfrom Mar 5, 2025
jayaddison:issue-94/gimp3-cmdline-compatibility
Merged
Makefile: update to GIMP3-compatible command-line#95frosch123 merged 1 commit intoOpenTTD:masterfrom jayaddison:issue-94/gimp3-cmdline-compatibility
frosch123 merged 1 commit intoOpenTTD:masterfrom
jayaddison:issue-94/gimp3-cmdline-compatibility
Conversation
- Specify the batch script interpreter to use; GIMP3 provides multiple. - Use `gimp-console` instead of `gimp` to avoid a non-interactive mode issue[1]. This doesn't solve all compatibility problems with GIMP3 yet; we also need to resolve the removal of a `gimp-image-get-active-layer` API function in GIMP3. The changes* here are intended to be backwards-compatible to GIMP2 and have been tested GIMP2.10.34 on Debian stable (bookworm), and also with GIMP3.0.0 RC2 to build the OpenGFX 7.1 sources. - [1] https://gitlab.gnome.org/GNOME/gimp/-/issues/12042 *NB: the `which` command has been superseded by `command -v` since v7.1 in VCS, so a small patch adjustment is required if backporting.
frosch123
approved these changes
Mar 5, 2025
Contributor
Author
|
Thanks @frosch123! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular:
Specify the batch script interpreter to use; GIMP3 provides multiple.
Use
gimp-consoleinstead ofgimpto avoid a non-interactive mode issue.This doesn't solve all compatibility problems with GIMP3 yet; we also need to resolve the removal of a
gimp-image-get-active-layerAPI function in GIMP3.The changes* here are intended to be backwards-compatible to GIMP2 and have been tested GIMP2.10.34 on Debian stable (bookworm), and also with GIMP3.0.0 RC2 to build the OpenGFX 7.1 sources.
*NB: the
whichcommand has been superseded bycommand -vsince v7.1 in VCS, so a small patch adjustment is required if backporting.