Merge pull request #2737 from nxglabs/sync-to-public_repo-32459158600 - #2247
Merged
Conversation
Merge pull request #2736 from nxglabs/raktima-main-patch-security
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates OpenSign’s server-side email/link generation and document metadata, and extends client localization for a new “monthly email credits limit reached” message.
Changes:
- Add RFC 2047 (base64) MIME encoding for non-ASCII display names in Gmail
From:headers. - Persist request origin IP (
OriginIp) when creating documents from the app, and prefer browserOriginfor custom-domain signing links in batch sends. - Add a new i18n key (
quota-mail-limit-reached) across multiple locales.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/cloud/parsefunction/sendMailGmailProvider.js | Adds encodeMimeAddress() and applies it to From: when constructing raw Gmail messages. |
| apps/OpenSignServer/cloud/parsefunction/createDocumentFromApp.js | Stores OriginIp on newly created contracts_Document records. |
| apps/OpenSignServer/cloud/parsefunction/createBatchDocs.js | Prefers request.headers.origin for publicUrl (custom-domain signing links). |
| apps/OpenSign/public/locales/kr/translation.json | Adds quota-mail-limit-reached Korean translation. |
| apps/OpenSign/public/locales/it/translation.json | Adds quota-mail-limit-reached Italian translation. |
| apps/OpenSign/public/locales/hi/translation.json | Adds quota-mail-limit-reached Hindi translation. |
| apps/OpenSign/public/locales/fr/translation.json | Adds quota-mail-limit-reached French translation. |
| apps/OpenSign/public/locales/es/translation.json | Adds quota-mail-limit-reached Spanish translation. |
| apps/OpenSign/public/locales/en/translation.json | Adds quota-mail-limit-reached English translation. |
| apps/OpenSign/public/locales/de/translation.json | Adds quota-mail-limit-reached German translation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+42
to
+46
| const value = String(address || ''); | ||
| const match = value.match(/^(.*?)\s*<([^<>]+)>$/); | ||
| const displayName = match ? match[1].trim() : value; | ||
|
|
||
| if (/^[\x00-\x7F]*$/.test(displayName)) return value; |
Comment on lines
+330
to
+331
| // Use the browser origin so signing links keep the custom domain. | ||
| let publicUrl = request.headers.origin || request.headers.public_url; |
| "quota-mail-info": "To maintain service quality and prevent spam, OpenSign allows up to 15 emails per month on the free plan. Upgrade now for unlimited email sending.", | ||
| "quota-mail-reset": "Your signature request email credits will be reset on", | ||
| "quota-mail": "You've reached your limit of 15 signature request emails for this month. Upgrade now to continue sending emails directly.", | ||
| "quota-mail-limit-reached": "You've reached your monthly limit of 15 email credits. Please upgrade your plan to continue sending emails directly.\nYour email credits will reset on {{resetDate}}", |
pravinOpenSign
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #2736 from nxglabs/raktima-main-patch-security