Skip to content

Remove SessionService.UpdateOlderSessions #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucHeart merged 1 commit into from
Apr 20, 2025
+3 −51
Merged

Remove SessionService.UpdateOlderSessions #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 3 additions & 51 deletions Common/Services/Session/SessionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,38 +43,17 @@ await _loginSessions.InsertAsync(new LoginSession

public async Task<IReadOnlyList<LoginSession>> ListSessionsByUserId(Guid userId)
{
var sessions = await _loginSessions.Where(x => x.UserId == userId).ToArrayAsync();

var needsSave = false;
foreach (var session in sessions)
{
needsSave |= UpdateOlderSessions(session);
}

if (needsSave)
{
await _loginSessions.SaveAsync();
}

return sessions;
return await _loginSessions.Where(x => x.UserId == userId).ToArrayAsync();
}

public async Task<LoginSession?> GetSessionById(string sessionId)
{
var session = await _loginSessions.FindByIdAsync(sessionId);

if (UpdateOlderSessions(session)) await _loginSessions.SaveAsync();

return session;
return await _loginSessions.FindByIdAsync(sessionId);
}

public async Task<LoginSession?> GetSessionByPulbicId(Guid publicSessionId)
{
var session = await _loginSessions.Where(x => x.PublicId == publicSessionId).FirstOrDefaultAsync();

if (UpdateOlderSessions(session)) await _loginSessions.SaveAsync();

return session;
return await _loginSessions.Where(x => x.PublicId == publicSessionId).FirstOrDefaultAsync();
}

public async Task UpdateSession(LoginSession session, TimeSpan ttl)
Expand Down Expand Up @@ -104,31 +83,4 @@ public async Task DeleteSession(LoginSession loginSession)
{
await _loginSessions.DeleteAsync(loginSession);
}

private static bool UpdateOlderSessions(LoginSession? session)
{
if (session == null) return false;

var save = false;

if (session.PublicId == null)
{
session.PublicId = Guid.CreateVersion7();
save = true;
}

if (session.Created == null)
{
session.Created = DateTime.UtcNow;
save = true;
}

if (session.Expires == null)
{
session.Expires = DateTime.UtcNow;
save = true;
}

return save;
}
}