feat: surface native app downloads in web About settings - #828
Open
AnthonyRonning wants to merge 3 commits into
Open
feat: surface native app downloads in web About settings#828AnthonyRonning wants to merge 3 commits into
AnthonyRonning wants to merge 3 commits into
Conversation
Web users looking for a desktop or mobile installer can now find platform download links on Settings → About, next to where desktop already exposes automatic updates. The picker suggests the current browser OS and still lets people choose macOS, Windows, Linux, iOS, or Android, matching GitHub release assets the same way the marketing site does. Related to #779.
Deploying maple with
|
| Latest commit: |
8980247
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e367f5ba.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-downloads-779-maple.maple-ca8.pages.dev |
Contributor
Author
|
Reviewers: Factory Droid (Kimi K3) and GLM 5.3 are reviewing this first cut of the Settings → About download path for #779. Banner placement is still TBD. |
Point unmatched GitHub installer links at the latest releases page instead of versioned filenames that 404 when package.json is ahead of the published tag. Also move the platform radiogroup with ArrowUp/Down and Home/End.
Cover web / desktop / mobile gating independently of injected props, and narrow resolveDownloadUrlsFromRelease to the assets field it actually uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web testers looking for a desktop download link expected to find it in Settings. This adds a Get the Maple app section on Settings → About for the web view only, in the same place desktop already shows automatic-update controls.
_universal.dmg,_x64-setup.exe, AppImage/deb/rpm, APK)Banner placement from #779 is still TBD. This is the Settings/About first cut.
Test plan
bun --no-env-file testfor the new About/download/GitHub helpersRelated to #779.