Skip to content

cachedb_memcached, cachedb_cassandra: fix NULL deref in connection init #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dondetir wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −3
Open

cachedb_memcached, cachedb_cassandra: fix NULL deref in connection init #3849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a11f4
cachedb_memcached: fix NULL deref when memcached_create() returns NULL
dondetir Mar 29, 2026
6cf5380
cachedb_cassandra: fix NULL deref when cass_cluster_new() returns NULL
dondetir Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/cachedb_cassandra/cachedb_cassandra_dbase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,13 @@ int cassandra_reopen(cassandra_con *cass_con)
int cassandra_new_connection(cassandra_con *con, char *host, int port, char *username, char *password)
{
con->cluster = cass_cluster_new();
if (username && password) {
cass_cluster_set_credentials(con->cluster, username, password);
}
if (!con->cluster) {
LM_ERR("Failed to create Cassandra Cluster object\n");
return -1;
}
if (username && password) {
cass_cluster_set_credentials(con->cluster, username, password);
}

#if CASS_VERSION_MAJOR >= 2 && CASS_VERSION_MINOR >= 15
/* since version 2.15, DSE support is available in the standard driver
Expand Down
5 changes: 5 additions & 0 deletions modules/cachedb_memcached/cachedb_memcached.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,11 @@ memcached_con* memcached_new_connection(struct cachedb_id *id)
con->ref = 1;

con->memc = memcached_create(NULL);
if (!con->memc) {
LM_ERR("failed to create memcached handle\n");
pkg_free(con);
return 0;
}

memset(host_buff,0,MAX_HOSTPORT_SIZE);

Expand Down