Skip to content

Fix lora_combiner docs. #11

Open
excepto64 wants to merge 1 commit into
OpenRLHF:mainfrom
excepto64:patch-1
Open

Fix lora_combiner docs. #11
excepto64 wants to merge 1 commit into
OpenRLHF:mainfrom
excepto64:patch-1

Conversation

@excepto64

Copy link
Copy Markdown

To solve issue #10.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in docs/source/common_options.rst to use --ds.param_dtype bf16 in an example command. However, the reviewer noted that the lora_combiner script is a standalone utility that does not support this DeepSpeed-specific parameter, and suggested using the --bf16 flag instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

--output_path ./checkpoint/llama-3-8b-rm-combined \
--is_rm \
--param_dtype bf16
--ds.param_dtype bf16

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lora_combiner script is a standalone utility that does not use the DeepSpeed trainer's dotted argument parser. It does not support --ds.param_dtype bf16. Instead, it uses a simple --bf16 boolean flag to enable bfloat16 precision during merging.

Suggested change
--ds.param_dtype bf16
--bf16

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not square with the output I got while running the code:

usage: lora_combiner.py [-h] --model_path MODEL_PATH --lora_path LORA_PATH
                        --output_path OUTPUT_PATH [--is_rm]
                        [--ds.param_dtype {bf16,fp16}]
lora_combiner.py: error: unrecognized arguments: --param_dtype bf16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant