Fix lora_combiner docs. #11
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in docs/source/common_options.rst to use --ds.param_dtype bf16 in an example command. However, the reviewer noted that the lora_combiner script is a standalone utility that does not support this DeepSpeed-specific parameter, and suggested using the --bf16 flag instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| --output_path ./checkpoint/llama-3-8b-rm-combined \ | ||
| --is_rm \ | ||
| --param_dtype bf16 | ||
| --ds.param_dtype bf16 |
There was a problem hiding this comment.
There was a problem hiding this comment.
This does not square with the output I got while running the code:
usage: lora_combiner.py [-h] --model_path MODEL_PATH --lora_path LORA_PATH
--output_path OUTPUT_PATH [--is_rm]
[--ds.param_dtype {bf16,fp16}]
lora_combiner.py: error: unrecognized arguments: --param_dtype bf16
To solve issue #10.