Skip to content

ImageList: start at index 0, use better starting colours #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gymnasiast merged 1 commit into from
Feb 28, 2026
Merged

ImageList: start at index 0, use better starting colours #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/imageList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ namespace ImageList {
}

function open() {
let startId = 14222;
let startId = 0;
Copy link
Member

@AaronVanGeffen AaronVanGeffen Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea as to why this was set this high in the first place? Old G2 offset or something?

Copy link
Member Author

@Gymnasiast Gymnasiast Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s the start of the track previews in the Appearance tab of the Ride window. My best guess is that Ted set it because he was working on something related to that, and didn’t change it back to 0 when committing the file.

Copy link
Member

@AaronVanGeffen AaronVanGeffen Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Probably more interesting than the first G1 sprites anyway.

Maybe we could use persistent storage to save/load the current offset between sessions? Not necessarily for this PR of course.

let nextId = 0;
let showImageBorders = false;
let primaryChecked = false;
let secondaryChecked = false;
let primaryColour = 4;
let secondaryColour = 18;
let tertiaryColour = 30;
let primaryColour = 7;
let secondaryColour = 30;
let tertiaryColour = 18;

const width = ui.width - 64;
const height = ui.height - 96;
Expand Down