packaging: remove legacy .egg references from Makefile.com#429
Open
abubakarsabir924-cell wants to merge 1 commit intoOpenPrinting:masterfrom
Open
packaging: remove legacy .egg references from Makefile.com#429abubakarsabir924-cell wants to merge 1 commit intoOpenPrinting:masterfrom
abubakarsabir924-cell wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
abubakarsabir924-cell
force-pushed
the
remove-legacy-egg-references
branch
from
0b3a208 to
a97b297
Compare
Author
|
Hi @tillkamppeter Sir, I have updated the Pull Request. I've commented out the legacy .egg and egg-info references in Makefile.am as requested. Also, I've cleaned up the indentation to ensure the PR is neat. Please have a look. Thank you |
Member
|
Can one not just delete these lines instead of commenting them out? |
abubakarsabir924-cell
force-pushed
the
remove-legacy-egg-references
branch
from
a97b297 to
820a3f8
Compare
Author
|
Hi @tillkamppeter ! I have deleted the legacy lines as suggested. To be honest, I was initially cautious and only commented them out because I didn't want to accidentally break anything in such a major organization. I wanted to move step-by-step to ensure total accuracy, as it is my dream to work with you and the OpenPrinting team for GSoC. The PR is now clean and ready for review. Thank you for your guidance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the request by Till Kamppeter to clean up legacy Python packaging references. I have commented out the .egg and egg-info cleanup rules in Makefile.am as they are no longer required for modern build systems.