Fix stack-buffer-overflow in ppdCacheCreateWithPPD()#70
Merged
tillkamppeter merged 2 commits intoOpenPrinting:masterfrom May 2, 2026
Merged
Fix stack-buffer-overflow in ppdCacheCreateWithPPD()#70tillkamppeter merged 2 commits intoOpenPrinting:masterfrom
tillkamppeter merged 2 commits intoOpenPrinting:masterfrom
Conversation
|
|
||
| *% These constraints are used to test ppdConflicts() and cupsResolveConflicts() | ||
| *cupsUIConstraints envelope: "*PageSize Letter *InputSlot Envelope" | ||
| *cupsUIConstraints envelope: "*PageSize߾��ն��������ߺ���������՜�������������ߚ����������ն��������߲anual *PageSize Env10" |
Member
There was a problem hiding this comment.
I assume that this messy line is not a trigger for this bug (the invalid/out-of-range maximum custom page size dimensions are). So could you edit this line to be something readable? Or just delete this line?
| *PaperDimension A4: "595 842" | ||
| *PaperDimension Env10: "297 684" | ||
|
|
||
| *% Custom page size support |
Member
There was a problem hiding this comment.
Could you here tell with a comment that we use invalid/out-of-range maximum paper dimensions to trigger the bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for the return value of pwgFormatSizeName() to avoid continuing with an empty buffer.
Also added the crash PPD file (sbo_test.ppd) and a regression test in testppd.c that opens it and calls ppdCacheCreateWithPPD().
This ensures make check catches the issue if it ever breaks again. All tests are passing.
Fixes #69