Fix Docker: embed rpath and copy libcups.so.2 into runtime stage (issue #1275)#1582
Open
abubakarsabir924-cell wants to merge 3 commits into
Conversation
PR OpenPrinting#1153 introduced a multi-stage Dockerfile but left two bugs: 1. libcups.so.2 was not copied into the runtime stage, causing: error while loading shared libraries: libcups.so.2: cannot open shared object file: No such file or directory 2. Runtime apt dependencies (openssl, libavahi-client3, etc.) were missing from the runtime stage. Fix: - Pass LDFLAGS='-Wl,-rpath,/usr/lib64' at configure time - Explicitly COPY libcups.so.2 into runtime stage - Install correct runtime packages in runtime stage - Add Browsing No to prevent avahi crash in container - Run ldconfig in runtime stage Fixes OpenPrinting#1275
Contributor
Author
|
Hi @michaelrsweet Sir, I've been investigating issue #1275 where docker compose up fails After deep analysis I found two root causes from PR #1153:
I tested this fix on Debian Linux:
Also fixed avahi assertion crash (browser.c:245) by adding Would appreciate your review. Thanks! |
michaelrsweet
added
bug
michaelrsweet
requested changes
May 19, 2026
- Remove LDFLAGS rpath (not needed, not portable across architectures) - Use make install DESTDIR=/buildroot instead of copying individual files - Add lib64->lib symlink and run ldconfig for library discovery Tested: container stays Up, curl returns HTTP 200
Contributor
Author
|
Sir @michaelrsweet, Updated the fix based on your review feedback:
Tested on Debian Linux:
Thanks for the review! |
Previous approach used /usr/lib64 which is x86_64 specific and not present in Ubuntu's ldconfig search path. Using --libdir=/usr/lib at configure time ensures libcups.so.2 installs to the standard location that ldconfig finds on all architectures. Also using make install DESTDIR=/buildroot as suggested by @michaelrsweet to copy the entire build root instead of individual files. Tested: container stays Up, curl returns HTTP 200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1275
docker compose upstarts but container exits immediately with:/usr/sbin/cupsd: error while loading shared libraries: libcups.so.2:
cannot open shared object file: No such file or directory
Root Causes
were not copied from builder into runtime stage
Fix
Tested