Skip to content

M #-: Improve infra role#173

Open
Aletibazo wants to merge 6 commits intomasterfrom
infra
Open

M #-: Improve infra role#173
Aletibazo wants to merge 6 commits intomasterfrom
infra

Conversation

@Aletibazo
Copy link

  • Add support for OVS and OVS + DPDK interfaces for infra VMs
  • Add qemu-guest-agent to infra VM template
  • Add SEARCH_DOMAIN as supported context parameter
  • Install opennebula-node-kvm and configure libvirt as part of infra tasks

- Add support for OVS and OVS + DPDK interfaces for infra VMs
- Add qemu-guest-agent to infra VM template
- Add SEARCH_DOMAIN as supported context parameter
- Install opennebula-node-kvm and configure libvirt as part of infra tasks

Signed-off-by: Alejandro Mosteiro <amosteiro@opennebula.io>
@tinova tinova removed request for dann1 and tinova February 23, 2026 13:18
Signed-off-by: Alejandro Mosteiro <amosteiro@opennebula.io>
@Aletibazo Aletibazo requested a review from sk4zuzu February 24, 2026 11:10
@sk4zuzu
Copy link
Collaborator

sk4zuzu commented Feb 25, 2026

@Aletibazo This is really optional, but since this is called "Improve infra role" maybe we could rename *.j2 templates to *.jinja as it is the new recommended naming. For example my neovim no longer recognizes *.j2 files.. 🥹

Signed-off-by: Alejandro Mosteiro <amosteiro@opennebula.io>
Signed-off-by: Alejandro Mosteiro <amosteiro@opennebula.io>
Copy link
Collaborator

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aletibazo

These places have to be corrected after the rename:

xml: "{{ lookup('template', 'frontend.xml.j2') }}"

src: context.sh.j2

It seems you never tested your latest changes, please make sure 'pc' -> 'q35' change works.. 🙏

- Update devices to be compatible with machine type q35
- Update inputs and graphics devices to modern options
- Remove addresses for devices, let libvirt auto assign them
- Update deploy task to use .jinja extensions

Signed-off-by: Alejandro Mosteiro <amosteiro@opennebula.io>
@Aletibazo
Copy link
Author

You're right @sk4zuzu. I've addressed the issues you've pointed and pushed new changes. I've validated that the q35 changes work.

@balazsbme
Copy link
Contributor

Once this PR is merged https://github.com/OpenNebula/one-deploy/pull/190/changes it implies changes here as well:

in the repository role inclusion:
https://github.com/OpenNebula/one-deploy/pull/173/changes#diff-23dd39183b4a9d75b3a45c56977ca19e3ef6f2c27b430120c3dbb7d15d705611R21

change needed: repos_enabled --> repos_enabled_defaults

Following changes to the variables of the repository role,
the repos_enabled_defaults parameter should be used, as from
the other instances of role invocations.

Signed-off-by: Balazs Nemeth <bnemeth@opennebula.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants