Skip to content

Update test matrix #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeas31 merged 3 commits into from
Jan 29, 2026
Merged

Update test matrix #403

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cf4d73
update test matrix
syntron Dec 28, 2025
81c3bb9
cleanup test matrix; scale it down to 2x Python 2x OS, 2x OM
syntron Jan 28, 2026
ff8df7e
Merge branch 'master' into test_matrix
adeas31 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,19 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
python-version: ['3.10', '3.12', '3.13']
# test for:
# * Python 3.10 - oldest supported version
# * Python 3.12 - changes in OMCSession / OMCPath
# * Python 3.14 - latest Python version
python-version: ['3.10', '3.12', '3.14']
# * Linux using ubuntu-latest
# * Windows using windows-latest
os: ['ubuntu-latest', 'windows-latest']
omc-version: ['stable', 'nightly']
# * OM 1.25.0 - before changing definition of simulation overrides
Copy link
Copy Markdown
Member

@adeas31 adeas31 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't want to test a specific OM version.

Copy link
Copy Markdown
Contributor Author

@syntron syntron Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we? I can remove it; however, at this point we have a hard to find break due to the handling of the simulation related options. My idea was to check / verify this for a given time. Please also see the comment by @joewa about the use of older versions (#401 (comment))

Copy link
Copy Markdown
Member

@adeas31 adeas31 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OM releases around 2 versions every year, if we start testing specific versions then it will be too much.
The fixes done in PR #400 and #402 are backwards compatible so even if @joewa is using OM 1.25.5 it will still work.

Copy link
Copy Markdown
Contributor Author

@syntron syntron Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK; I scaled it down to 2x Python; 2x OS; 2x OM - the minimum number to test

# * OM stable - latest stable version
# * OM nightly - latest nightly build
omc-version: ['1.25.0', 'stable', 'nightly']
# => total of 3 (Python) * 2 (OS) * 3 (OM) = 19 runs for each test
Copy link
Copy Markdown
Member

@adeas31 adeas31 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18 runs for each test.

This is additional information that will quickly become outdated once a new Python version is added. I suggest not including this line, as it is easy to forget updating this part when other parts of the file are modified.

Copy link
Copy Markdown
Contributor Author

@syntron syntron Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite right! - I did remove the line ...


steps:
- uses: actions/checkout@v6
Expand Down