Add High Res MS and Low Res MS presets for Comet adapter#6
Merged
t0mdavid-m merged 3 commits intomainfrom Jan 29, 2026
Merged
Conversation
Add High-Res and Low-Res presets for CometAdapter: - High-Res (< 50 ppm): instrument=high_res, fragment_mass_tolerance=0.015 Da, fragment_bin_offset=0.0 - Low-Res (>= 50 ppm): instrument=low_res, fragment_mass_tolerance=0.50025 Da, fragment_bin_offset=0.4 https://claude.ai/code/session_01B8uy8fQnZ9q2tRsCiLuTev
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe presets.json file was restructured to replace "High Sensitivity" with "High Res MS" and introduce "Low Res MS", while removing "High Specificity", "Fast Analysis", and "Metabolomics Default" presets and their nested parameter blocks. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added two new instrument-specific presets to optimize Comet adapter configuration for different mass spectrometry resolution types.
Changes
High Res MS preset: Optimized for high-resolution MS2 instruments (Orbitrap, TOF)
high_resLow Res MS preset: Optimized for low-resolution MS2 instruments (Ion trap)
low_resDetails
These presets provide sensible defaults for users working with different mass spectrometry instruments, eliminating the need for manual configuration of instrument-specific parameters. The fragment mass tolerance and bin offset values are calibrated for each instrument class to balance sensitivity and specificity.
https://claude.ai/code/session_01B8uy8fQnZ9q2tRsCiLuTev
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.