Unify the API for subsystem builder methods.#1009
Merged
jkirk5 merged 46 commits intoOpenMDAO:mainfrom Apr 1, 2026
Merged
Conversation
jkirk5
requested changes
Mar 19, 2026
jkirk5
reviewed
Mar 19, 2026
jkirk5
reviewed
Mar 23, 2026
jkirk5
reviewed
Mar 23, 2026
jkirk5
reviewed
Mar 23, 2026
jkirk5
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands the arguments to many of the subsystem builder methods to include aviary_inputs, phase_info, and the phase_name where they were applicable.
define_ordermethod from the phase_builder API. It never did anything, and that capability is a little tricky to do this way.Related Issues
Backwards incompatibilities
Users will have to edit their subsystems to add the missing arguments.
In addition, an error will be raised if a subsystem builder contains the
get_bus_variablesmethod, which was renamed in an earlier PR toget_pre_mission_bus_variables.New Dependencies
None