Skip to content

fix(qbittorrent): handle non-200 response during login to prevent long startup waits #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airium wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(qbittorrent): handle non-200 response during login to prevent long startup waits #2248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/qbittorrent/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func New(webuiUrl string) (Client, error) {
IdleConnTimeout: 30 * time.Second,
DisableKeepAlives: false, // Enable connection reuse
}

var c = &client{
url: u,
client: http.Client{
Expand Down Expand Up @@ -98,6 +98,13 @@ func (c *client) login() error {
}
defer resp.Body.Close()

// avoid long waiting time if being upgraded to websocket connections (e.g. 101 responses)
// as per API documentation, qBittorrent returns only 200 on successful login
// so we safely treat any non-200 response as a failure
if resp.StatusCode != http.StatusOK {
return errors.New("failed to login into qBittorrent webui with status code: " + resp.Status)
}

// check result
body := make([]byte, 2)
_, err = resp.Body.Read(body)
Expand Down
Loading