Skip to content

Added labels for addresses #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharliePlett wants to merge 1 commit into
base: staging
Choose a base branch
from
+62 −1
Open

Added labels for addresses #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion historical/historical.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6162,6 +6162,56 @@
"text-opacity": ["interpolate", ["linear"], ["zoom"], 13.99, 0, 14, 1]
}
},
{
"id": "address_points_labels",
"type": "symbol",
"source": "ohm",
"source-layer": "address_points",
"minzoom": 16,
"filter": ["has", "addr_housenumber"],
"layout": {
"text-field": ["get", "addr_housenumber"],
"text-size": ["interpolate", ["linear"], ["zoom"], 16, 8, 17, 9, 20, 10],
"text-anchor": "top",
"text-offset": [0, 1],
"text-font": ["OpenHistorical"],
"visibility": "visible"
},
"paint": {
"text-color": "rgba(80, 80, 80, 1)",
"text-halo-color": "rgba(255, 255, 255, 1)",
"text-halo-width": 1,
"text-halo-blur": 0.5,
"text-opacity": ["interpolate", ["linear"], ["zoom"], 16.99, 0, 17, 1]
}
},
{
"id": "buildings_address_labels",
"type": "symbol",
"source": "ohm",
"source-layer": "buildings",
"minzoom": 16,
"filter": [
"all",
["has", "addr_housenumber"],
["any", ["!", ["has", "name"]], ["==", ["get", "name"], ""]]
],
"layout": {
"text-field": ["get", "addr_housenumber"],
"text-size": ["interpolate", ["linear"], ["zoom"], 16, 8, 17, 9, 20, 10],
"text-anchor": "top",
"text-offset": [0, 1],
"text-font": ["OpenHistorical"],
"visibility": "visible"
},
"paint": {
"text-color": "rgba(80, 80, 80, 1)",
"text-halo-color": "rgba(255, 255, 255, 1)",
"text-halo-width": 1,
"text-halo-blur": 0.5,
"text-opacity": ["interpolate", ["linear"], ["zoom"], 16.99, 0, 17, 1]
}
},
{
"id": "points_of_interest_buildings",
"type": "symbol",
Expand All @@ -6172,7 +6222,18 @@
"layout": {
"icon-image": "{tourism}-18",
"visibility": "visible",
"text-field": ["get", "name"],
"text-field": [
"case",
["all", ["has", "name"], ["has", "addr_housenumber"]],
[
"concat",
["get", "name"],
" (",
["get", "addr_housenumber"],
")"
Comment on lines +6231 to +6233

@1ec5 1ec5 Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting the house number on a separate line (\n)? The parentheses won’t be necessary, especially if you make the house number slightly smaller than the rest of the label. You can do this by replacing the concat expression with a format expression. Once we integrate Diplomat in OpenHistoricalMap/issues#799, the house number will appear after the local-language gloss.

],
["get", "name"]
],
"text-size": ["interpolate", ["linear"], ["zoom"], 16, 12, 17, 14, 20, 16],
"text-anchor": "center",
"text-offset": [0, 0],
Expand Down