fix: make published package root importable#255
Draft
enyst wants to merge 1 commit into
Draft
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
4 tasks
Contributor
Endpoint audit❌ 6 off-contract call(s) — not on the agent-server · classifiers: cloud
❌ Not on agent-server (gated, 6)⛔ (no known backend) — served by no backend we can see (5)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #135 asks whether publishing
@openhands/typescript-clientis solved. Investigation found the package is published to npm as1.28.0with the expected subpath exports and publish workflows, but the published root import currently fails in Node ESM becausedist/models/acp.jsimportsacp-providers.jsonwithout a JSON import attribute.Fixes #135.
Summary
Issue Number
Fixes #135
How to Test
npm run buildnpm run lint(passes with existing warnings)npm run test:coveragenpm run format:checknpm run test:git-dependency@openhands/typescript-client@openhands/typescript-client/clients@openhands/typescript-client/client/http-client@openhands/typescript-client/events/remote-events-list@openhands/typescript-client/workspace/remote-workspaceVideo/Screenshots
N/A — package/runtime import fix only.
Type
Notes
Current package shape from the investigation:
@openhands/typescript-client@1.28.0is published on npm: https://www.npmjs.com/package/@openhands/typescript-clientpackage.jsonexports include.,./clients,./client/http-client,./events/remote-events-list, and./workspace/remote-workspace.dist/**/*, including generated test helper files underdist/__tests__; this PR does not change that packaging surface.This PR was created by an AI agent (OpenHands) on behalf of the user.
@enyst can click here to continue refining the PR