feat(qa-changes): capture visual evidence for frontend PRs#403
Open
smolpaws wants to merge 1 commit into
Open
Conversation
Add a Phase 3 step: when a PR has frontend work, run the affected screens from the branch's final state and capture a screenshot of each relevant state (empty, loading, error, populated) plus a GIF of the key interaction end to end. Where behavior changes, include before/after. Attach it all to the PR so the change can be reviewed by observation, not by reading the diff. Adds a matching 'Visual Evidence' block to the report format and a key principle, and regenerates the skills catalog. Co-authored-by: smolpaws <engel@enyst.org>
smolpaws
force-pushed
the
qa-visual-evidence
branch
from
4f0b766 to
5f35ee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a step to the
qa-changesskill: capture visual evidence for frontend PRs.If the PR has frontend work, QA should run the affected screens from the branch's final state and record what a reviewer would otherwise have to imagine from the diff — so the change can be reviewed by observation, not by reading code.
The step
For frontend PRs, after exercising the UI:
.pr/and reference the raw URLs. Label each clearly.Kept proportional (only the screens the PR touches) with an explicit "say so if you can't render a screen" escape hatch — consistent with the skill's existing "give up gracefully / report honestly" ethos.
Changes
skills/qa-changes/SKILL.md: new "Capture visual evidence" step in Phase 3, a "Visual Evidence" collapsible in the report format, and a matching key principle.skills/index.js: regenerated skills catalog (node scripts/build-skills-catalog.mjs).Docs-only change to a skill; no code paths affected.