-
Notifications
You must be signed in to change notification settings - Fork 73
Add config option to include drop fixes #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,6 +74,9 @@ int settings::EVENTMODE = 0; | |
| // race settings | ||
| bool settings::IZRACESCORECAPPED = true; | ||
|
|
||
| // drop fixes enabled | ||
| bool settings::DROPFIXESENABLED = false; | ||
|
|
||
| void settings::init() { | ||
| INIReader reader("config.ini"); | ||
|
|
||
|
|
@@ -117,6 +120,7 @@ void settings::init() { | |
| TDATADIR = reader.Get("shard", "tdatadir", TDATADIR); | ||
| PATCHDIR = reader.Get("shard", "patchdir", PATCHDIR); | ||
| ENABLEDPATCHES = reader.Get("shard", "enabledpatches", ENABLEDPATCHES); | ||
| DROPFIXESENABLED = reader.GetBoolean("shard", "dropfixesenabled", DROPFIXESENABLED); | ||
| ACCLEVEL = reader.GetInteger("shard", "accountlevel", ACCLEVEL); | ||
| EVENTMODE = reader.GetInteger("shard", "eventmode", EVENTMODE); | ||
| DISABLEFIRSTUSEFLAG = reader.GetBoolean("shard", "disablefirstuseflag", DISABLEFIRSTUSEFLAG); | ||
|
|
@@ -126,4 +130,13 @@ void settings::init() { | |
| MONITORPORT = reader.GetInteger("monitor", "port", MONITORPORT); | ||
| MONITORLISTENIP = reader.Get("monitor", "listenip", MONITORLISTENIP); | ||
| MONITORINTERVAL = reader.GetInteger("monitor", "interval", MONITORINTERVAL); | ||
|
|
||
| if (DROPFIXESENABLED) { | ||
| std::cout << "[INFO] Drop fixes enabled" << std::endl; | ||
| if (ENABLEDPATCHES.empty()) { | ||
| ENABLEDPATCHES = "0104-fix"; | ||
| } else { | ||
| ENABLEDPATCHES += " 0104-fix 1013-fix"; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: I would rename these to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, makes sense. |
||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would re-word this to clarify what exactly "fix" means. Something like: "This adds drops to mobs that previously didn't have any or drops that weren't in the drop table. This is polish that is slightly inauthentic to the original game."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer, thanks!