Skip to content

don't write no-ops as new URL history items#4813

Open
taylordowns2000 wants to merge 2 commits into
mainfrom
triple-click-to-go-back-once
Open

don't write no-ops as new URL history items#4813
taylordowns2000 wants to merge 2 commits into
mainfrom
triple-click-to-go-back-once

Conversation

@taylordowns2000
Copy link
Copy Markdown
Member

Description

This pr closes #4812 by preventing no-ops (where previous URL == new URL) from being added as new URL history items.

Validation steps

  1. Go to workflow list
  2. Click into workflow
  3. Click back
  4. See that it works after a single click, not 3 clicks

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation Bot moved this to New Issues in Core May 29, 2026
@github-actions
Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — change is entirely client-side history.pushState deduplication in assets/js/react/lib/use-url-state.ts:105, no data access.
  • S1 (authorization): N/A — no new web-layer actions, controllers, or LiveView events introduced.
  • S2 (audit trail): N/A — no config-resource writes; only browser URL/history behavior changed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.3%. Comparing base (4e910ec) to head (927c28e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4813   +/-   ##
=====================================
  Coverage   90.3%   90.3%           
=====================================
  Files        442     442           
  Lines      22543   22543           
=====================================
+ Hits       20350   20354    +4     
+ Misses      2193    2189    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Must click "back" 3x to go back after navigating to canvas

1 participant