Bump Tesla to 1.18.2 to fix mid-stream transport error crashes#4782
Open
elias-ba wants to merge 1 commit into
Open
Bump Tesla to 1.18.2 to fix mid-stream transport error crashes#4782elias-ba wants to merge 1 commit into
elias-ba wants to merge 1 commit into
Conversation
Security Review ✅
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
=======================================
- Coverage 90.2% 90.2% -0.0%
=======================================
Files 442 442
Lines 22439 22439
=======================================
- Hits 20242 20236 -6
- Misses 2197 2203 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades Tesla from 1.15.3 to 1.18.2. The Finch adapter in 1.15.3 raises
CaseClauseErroron the 3-tuple error shape Finch returns when a streaming connection drops mid-response, which crashes the AI assistant worker. Tesla 1.16.0 (elixir-tesla/tesla#819) handles the shape gracefully so the worker can return a normal error; 1.18.2 is the latest stable on that line.Closes #4781.
Validation steps
mix compile --warnings-as-errorssucceeds.apollo_client,adaptor_registry,auth_providers,github_client,usage_tracking,ai_assistant,version_control.Additional notes for the reviewer
AI Usage
Pre-submission checklist