fix: auto-convert project name in settings form#4436
Open
Conversation
The project creation form auto-converts uppercase and spaces to the lowercase-hyphens-digits format, but the settings form did not, causing users to get a validation error when entering names like "DEP-burundi-datafi". Aligns the settings form with the creation form by using a raw_name input that gets converted via Helpers.url_safe_name/1 before saving.
The project name input was changed from `name` to `raw_name` for the url-safe conversion feature, but two test assertions still referenced the old field name.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 89.33% 89.38% +0.05%
==========================================
Files 425 425
Lines 20133 20137 +4
==========================================
+ Hits 17985 17999 +14
+ Misses 2148 2138 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the project settings form to auto-convert project names to url-safe format (lowercase, hyphens, digits), matching the behavior of the project creation form.
Previously, entering a name like "DEP-burundi-datafi" in settings would fail validation since the form submitted the raw input directly. The creation form already handled this by converting via
Helpers.url_safe_name/1, but the settings form did not.Closes #4437
Validation steps
Additional notes for the reviewer
raw_namefield is not a virtual schema field — it's just a form input key that gets intercepted and converted before reaching the changeset (same pattern as the creation modal)AI Usage
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)