feat: allow assistant to work on unsaved jobs#4416
Conversation
… job_chat? @doc false is unnecessary on private functions. Renamed predicate to follow Elixir convention and fix Credo lint failure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
+ Coverage 89.26% 89.34% +0.07%
==========================================
Files 425 425
Lines 20090 20128 +38
==========================================
+ Hits 17933 17983 +50
+ Misses 2157 2145 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
left a comment
There was a problem hiding this comment.
Hey @doc-han this is a really nice little feature that will have a huge impact on the AI Assistant's UX. Thanks a lot dude. I have left a few questions (mainly for my own curiosity and learning). I could approve this as is, but I think you'll need to add a few tests to cover at least the new handle_unsaved_job_message path in the channel and the job_chat? / update_session_with_job_context logic in the message processor.
|
This is probably unrelated @doc-han but here's another issue in the same area:
|
noted and resolved. |
elias-ba
left a comment
There was a problem hiding this comment.
Nicely done Commander Han ! ⚔️
|
What about those failing tests? Do they need fixing or can we merge? |
|
Hey @josephjclark no failing tests but we could improve the coverage of the ai_assistant_channel.ex. Let me push a commit with one test that could do us good here. |
|
@elias-ba dealing with that |
|
@elias-ba codecov looking good now. thanks |


Description
This PR allows the AI assistant to work on unsaved jobs.
Closes #4417 #4412
Validation steps
New unsaved workflow
Already saved workflow with new nodes
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)