Merged
Conversation
This is hand-coded just into identifier for now. But once value maps are set, this should automatically expand shorthands into values
Basically only done for identifiers, and still need tauto-load the mappings
Also some fixing around datatypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
PIcan expand to{ coding: [{ code: 'PI', system: '...' }] }b.patient({})works, you don't have to dob.patient('SzPatient', {})Cool things we can do now
Patient.identifier.type
Encounter.class
(note that the IG maps to over 1000 values from base fhir-4, plus like 4 values from the Eswataini IG. I've only mapped the 4 value - I need to go back and support the 1k in fhir-4 but the scale is kinda hard)
Details
This PR updates the eswatini and fhir-4 adaptors with the ability to map to values defined in valuesets via a shorthand syntax - so a simple string
PIcan expand to{ coding: [{ code: 'PI', system: '...' }] }What I particularly like is that the design of this means the mappings are soft-coded into the adaptor and can be updated by users. The generated adaptor will load a default set of value maps from the IG, but users can extend and map this from job code for big productivity wins.
What I've done:
What I still need to do:
Future Work
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy