Open
Conversation
Previously, the self-weight of the reaction node(s) is missing. This is now added back along with any cable loads on the reaction node(s) just in case.
Collaborator
|
@luwang00 -- Thanks for fixing this. You mention "added back". I thought this term was previously already included in SubDyn. Was it removed at some point (accidentally?) and now added back? |
Contributor
Author
|
@jjonkman Sorry, I wasn't that careful with the wording. I'm not sure when this bug was introduced. It might be that the self-weight was part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
Previously, the reaction loads from SubDyn is missing the self-weight of the reaction joint(s). This contribution is now added back. The cable loads on the reaction joint(s) are also added just in case.
Related issue, if one exists
Issue #3293
Impacted areas of the software
SubDyn
Test results, if applicable
Likely need to update some of the r-tests involving SubDyn