Fix arm64 build against current toolchain#10
Open
an1310 wants to merge 1 commit into
Open
Conversation
Member
|
Could you rebase this against master? |
f81680c to
d15a8bc
Compare
Author
|
I kept the project default on the rebase. I was using static_cast, but the style used by this branch was a simple byte cast. (Also reverted spaces to tabs because that was the project default as well, though I've been using spaces for 20+ years) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nestopia does not compile under current Xcode. Two issues:
integer expressions. C++11 makes narrowing in a braced initializer list
ill-formed, and current clang enforces it. The truncations are
intentional in serialization code, so
-Wc++11-narrowingis disabledfor the core target rather than casting each site.
NSData *returnedNOon its error path. Changed to returnnil.Builds arm64 against the macOS 26 SDK.