Update to work on ppc64le#7
Closed
piotrmaslanka wants to merge 1 commit intoOpenDroneMap:250from
piotrmaslanka:250
Closed
Update to work on ppc64le#7piotrmaslanka wants to merge 1 commit intoOpenDroneMap:250from piotrmaslanka:250
piotrmaslanka wants to merge 1 commit intoOpenDroneMap:250from
piotrmaslanka:250
Conversation
Since on POWER the input of abs() is promoted to an integer, this condition always holds. This is a fix that hopefully makes it work on ppc64le.
Member
|
Thanks @piotrmaslanka ✋ You are probably not fixing the issue though, since eps (epsilon) is generally a very small floating value. The proper fix would be to change this to If the compiler is using the int version of abs, then you're just comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since on POWER the input of abs() is promoted to an integer (or the result is), this condition always holds. This is a fix that hopefully makes it work on ppc64le, this was verified to work on ppc64le and returns valid results.
I've filed a concurrent pull request for OpenSfM itself, but it seems like they certainly do take their time...