Keep dense reconstruction topocentric while applying exact final georeferencing#2008
Open
lupionpe wants to merge 2 commits intoOpenDroneMap:masterfrom
Open
Keep dense reconstruction topocentric while applying exact final georeferencing#2008lupionpe wants to merge 2 commits intoOpenDroneMap:masterfrom
lupionpe wants to merge 2 commits intoOpenDroneMap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconstruction.jsonshots.geojsonoutputsCompanion OpenSfM PR
This PR is the ODM-side integration for the companion OpenSfM fix here:
The core georeferencing solution was proposed and implemented by Yann Noutary in:
Credit for the root fix is his. This PR is the downstream ODM integration needed to make that corrected transform reach the final orthoimage / point cloud outputs without breaking dense reconstruction.
I have some basic coding experience, but most of the porting / validation / integration work for this contribution was done with AI (Codex).
Context
Related discussions:
Validation
My conclusion after downstream validation is that this does seem to solve the root cause.
I ran two real tests on two different areas with roughly:
gcp.txt+geo.txtIn both cases the observed precision improved, as expected.
Checks I could run locally here:
python3 -m py_compile opendm/types.py opendm/osfm.py opendm/shots.py opendm/align.py stages/run_opensfm.py stages/odm_georeferencing.py stages/odm_report.py