Skip to content

Fix "Bad file descriptor" error when closing the serial transport #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavel-kirienko merged 2 commits into from
Jun 27, 2026
Merged

Fix "Bad file descriptor" error when closing the serial transport #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48da0e5
Fix "Bad file descriptor" error when closing the serial transport
kristkis Jun 26, 2026
9c37dad
Bump patch version to 1.27.1
kristkis Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycyphal/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.27.0"
__version__ = "1.27.1"
8 changes: 7 additions & 1 deletion pycyphal/transport/serial/_serial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,13 @@ def callback(ts: Timestamp, buf: memoryview, frame: typing.Optional[SerialFrame]
self._serial_port,
)
self._closed = True
self._serial_port.close()
try:
self._serial_port.close()
except Exception:
# close() is not atomic (see __init__), so when SerialTransport.close() runs at the
# same time, the reader thread can try to close an already-closed port. The resulting
# OSError is harmless, so ignore it.
pass

finally:
_logger.debug("%s: Reader thread is exiting. Head aega.", self)
Expand Down
Loading