Remove guest_qualifier / isMemberOf guest-status feature#2064
Open
kayjoosten wants to merge 1 commit into
Open
Remove guest_qualifier / isMemberOf guest-status feature#2064kayjoosten wants to merge 1 commit into
kayjoosten wants to merge 1 commit into
Conversation
Why is this change needed? Prior to this change, EngineBlock had a legacy feature (AddGuestStatus, FilterReservedMemberOfValues, coin:guest_qualifier) that added a reserved urn:collab:org value to isMemberOf based on an IdP's guest_qualifier setting, so SPs could tell full members from guests. The feature was confirmed unused (FCCN, the only suspected consumer, does not use it), is complex and non-obvious for deployers to configure, and is implemented in legacy Corto filter command code. How does it address the issue? Removes the AddGuestStatus and FilterReservedMemberOfValues filter commands from the input filter chain, the guestQualifier coin from Coins/IdentityProvider/PushMetadataAssembler/CortoDisassembler, the addgueststatus_guestqualifier parameter, related docs, and all test fixtures/assertions referencing guest_qualifier. #1294
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddGuestStatusandFilterReservedMemberOfValuesfilter commands, theguestQualifiercoin (Coins,IdentityProvider,PushMetadataAssembler,CortoDisassembler), and theaddgueststatus_guestqualifierparameter.guest_qualifier, and CHANGELOG.Test plan
guest_qualifierreferences repo-wide)./vendor/bin/phpunit --testsuite=unit./vendor/bin/phpunit --testsuite=integrationAPP_ENV=test ./vendor/bin/phpunit --testsuite=functionalCloses #1294